From: Colin Ian King <colin.k...@canonical.com>

pin is an unsigned int and therefore can never be < 0 so
this check is redudant. Remove the check and the associated
dev_err error message.

Fixes CoverityScan CID#1396438 ("Unsigned compared against 0")

Signed-off-by: Colin Ian King <colin.k...@canonical.com>
---
 drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c 
b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
index 3b86d3d..a345166 100644
--- a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
+++ b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
@@ -665,12 +665,6 @@ static void ti_iodelay_pin_dbg_show(struct pinctrl_dev 
*pctldev,
        r = iod->reg_data;
 
        offset = ti_iodelay_pin_to_offset(iod, pin);
-       if (pin < 0) {
-               dev_err(iod->dev, "invalid pin offset for pin%i\n", pin);
-
-               return;
-       }
-
        pd = &iod->pa[pin];
        cfg = pd->drv_data;
 
-- 
2.10.2

Reply via email to