Hi Mark, On 17 January 2017 at 20:29, Mark Rutland <[email protected]> wrote: > On Tue, Jan 17, 2017 at 06:18:12AM -0600, Timur Tabi wrote: >> Fu Wei wrote: >> >if (i >= ARCH_TIMER_MEM_MAX_FRAMES) { >> > pr_err(FW_BUG "too many frames, ARMv8 spec only allows 8.\n"); >> >> pr_err(FW_BUG "too many frames, ARMv8 spec only allows %u.\n", >> ARCH_TIMER_MEM_MAX_FRAMES); > > While I don't see ARCH_TIMER_MEM_MAX_FRAMES changing, this would be > nicer to ensure the result obviously matches. > > As for wording, I'd perfer: > > pr_err(FW_BUG "too many frames, only %u are permitted.\n", > ARCH_TIMER_MEM_MAX_FRAMES);
OK, will do so. Thanks! > > ... so as to avoid any confusion between spec versions and so on. We can > reconsider the message if/when that changes. > > Thanks, > Mark. -- Best regards, Fu Wei Software Engineer Red Hat
