On 01/17/2017 02:44 PM, David Miller wrote: > From: Christoph Hellwig <[email protected]> > Date: Mon, 16 Jan 2017 23:55:21 -0800 > >> On Mon, Jan 16, 2017 at 10:42:43PM -0500, David Miller wrote: >>> The lseek() done by dump_skip() should extend the file properly. >> >> lseek never extends a file. It just moves the current file position. >> So if you do not have a write after the lseek it does nothing. > > Ok, then the only other feedback I have is that we should probably > defer this truncate() call until the last possible dump write occurs > rather than right after the VMA loop.
Yeah. That's fine with me.
