Hi Neil,
On 17-01-2017 12:31, Neil Armstrong wrote: > If the input pixel format is not RGB, the CSC must be enabled in order to > provide valid pixel to DVI sinks. > This patch removes the hdmi only dependency on the CSC enabling. > > Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> I was going to say that you should make sure the output colorspace is RGB or else DVI will fail to work, but I just noticed the output colorspace is fixed in the code to RGB. Though, that may change in the future. Reviewed-by: Jose Abreu <joab...@synopsys.com> Best regards, Jose Miguel Abreu > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c > b/drivers/gpu/drm/bridge/dw-hdmi.c > index 923e250..8a6a183 100644 > --- a/drivers/gpu/drm/bridge/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/dw-hdmi.c > @@ -1331,8 +1331,8 @@ static void dw_hdmi_enable_video_path(struct dw_hdmi > *hdmi) > hdmi_writeb(hdmi, clkdis, HDMI_MC_CLKDIS); > } > > - /* Enable color space conversion if needed (for HDMI sinks only). */ > - if (hdmi->sink_is_hdmi && is_color_space_conversion(hdmi)) > + /* Enable color space conversion if needed */ > + if (is_color_space_conversion(hdmi)) > hdmi_writeb(hdmi, HDMI_MC_FLOWCTRL_FEED_THROUGH_OFF_CSC_IN_PATH, > HDMI_MC_FLOWCTRL); > else
