On Fri, 2007-03-09 at 10:15 +0200, Pekka J Enberg wrote:
> > + again:
> > + restart_addr = zap_page_range(vma, start_addr, end_addr - start_addr,
> > + details);
> > +
> > + need_break = need_resched() || need_lockbreak(details->i_mmap_lock);
> > + if (need_break)
> > + goto out_need_break;
> > +
> > + if (restart_addr < end_addr) {
> > + start_addr = restart_addr;
> > + goto again;
> > + }
> > + return 0;
> > +
> > + out_need_break:
> > + spin_unlock(details->i_mmap_lock);
> > + cond_resched();
> > + spin_lock(details->i_mmap_lock);
> > + return -EINTR;
On Fri, 2007-03-09 at 13:30 +0100, Peter Zijlstra wrote:
> I'm not sure this scheme works, given a sufficiently loaded machine,
> this might never complete.
Hmm, so what's the alternative? It's better to fail revoke than lock up
the box.
On Fri, 2007-03-09 at 13:30 +0100, Peter Zijlstra wrote:
> I'm never sure of operator precedence and prefer:
>
> (vma->vm_flags & VM_SHARED) && ...
>
> which leaves no room for error.
Thanks, fixed.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
