On Wed, Jan 18, 2017 at 09:46:25AM -0800, Guenter Roeck wrote: > There is no call to platform_get_drvdata() or dev_get_drvdata(). > Drop the unnecessary call to dev_set_drvdata(). > Other relevant changes: > Use existing variable 'dev' instead of dereferencing it several times > > This conversion was done automatically with coccinelle using the > following semantic patches. The semantic patches and the scripts > used to generate this commit log are available at > https://github.com/groeck/coccinelle-patches > > - Drop dev_set_drvdata() > - Use local variable 'struct device *dev' consistently > > Signed-off-by: Guenter Roeck <[email protected]>
Applied, thank you. > --- > drivers/input/keyboard/cros_ec_keyb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/input/keyboard/cros_ec_keyb.c > b/drivers/input/keyboard/cros_ec_keyb.c > index 25943e9bc8bf..87d071ae21da 100644 > --- a/drivers/input/keyboard/cros_ec_keyb.c > +++ b/drivers/input/keyboard/cros_ec_keyb.c > @@ -222,7 +222,7 @@ static int cros_ec_keyb_probe(struct platform_device > *pdev) > struct device_node *np; > int err; > > - np = pdev->dev.of_node; > + np = dev->of_node; > if (!np) > return -ENODEV; > > @@ -248,7 +248,6 @@ static int cros_ec_keyb_probe(struct platform_device > *pdev) > ckdev->ec = ec; > ckdev->notifier.notifier_call = cros_ec_keyb_work; > ckdev->dev = dev; > - dev_set_drvdata(dev, ckdev); > > idev->name = CROS_EC_DEV_NAME; > idev->phys = ec->phys_name; > -- > 2.7.4 > -- Dmitry
