On Wed, 2017-01-18 at 12:35 -0800, Guenter Roeck wrote:
> On Wed, Jan 18, 2017 at 11:39:52AM -0800, Dmitry Torokhov wrote:
> > On Wed, Jan 18, 2017 at 09:46:34AM -0800, Guenter Roeck wrote:
[]
> > > diff --git a/drivers/input/misc/bfin_rotary.c
> > > b/drivers/input/misc/bfin_rotary.c
[]
> > > @@ -141,25 +141,23 @@ static int bfin_rotary_probe(struct platform_device
> > > *pdev)
> > >
> > > /* Basic validation */
> > > if ((pdata->rotary_up_key && !pdata->rotary_down_key) ||
> > > - (!pdata->rotary_up_key && pdata->rotary_down_key)) {
> > > + (!pdata->rotary_up_key && pdata->rotary_down_key))
maybe just use ^
if (!pdata->rotary_up_key ^ !pdata->rotary_down_key)
