Re: [PATCH v1] PM / Domains: Keep the pd status during system PM phases

[kbuild test robot]

Hi Elaine,

[auto build test WARNING on pm/linux-next]
[also build test WARNING on v4.10-rc4 next-20170119]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Elaine-Zhang/PM-Domains-Keep-the-pd-status-during-system-PM-phases/20170120-091738
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git 
linux-next
config: x86_64-randconfig-x017-201703 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/base/power/domain.c: In function 'pm_genpd_suspend_noirq':
>> drivers/base/power/domain.c:885:29: warning: suggest parentheses around '&&' 
>> within '||' [-Wparentheses]
         dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev))
         ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/base/power/domain.c: In function 'pm_genpd_resume_noirq':
   drivers/base/power/domain.c:923:29: warning: suggest parentheses around '&&' 
within '||' [-Wparentheses]
         dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev))
         ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +885 drivers/base/power/domain.c

   869   *
   870   * Stop the device and remove power from the domain if all devices in 
it have
   871   * been stopped.
   872   */
   873  static int pm_genpd_suspend_noirq(struct device *dev)
   874  {
   875          struct generic_pm_domain *genpd;
   876          int ret;
   877  
   878          dev_dbg(dev, "%s()\n", __func__);
   879  
   880          genpd = dev_to_genpd(dev);
   881          if (IS_ERR(genpd))
   882                  return -EINVAL;
   883  
   884          if (genpd->suspend_power_off ||
 > 885              dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, 
 > dev))
   886                  return 0;
   887  
   888          if (genpd->dev_ops.stop && genpd->dev_ops.start) {
   889                  ret = pm_runtime_force_suspend(dev);
   890                  if (ret)
   891                          return ret;
   892          }
   893  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

.config.gz
Description: application/gzip