On 01/20/2017 04:16 AM, Thierry Reding wrote:
On Thu, Jan 19, 2017 at 02:40:55PM -0800, Dmitry Torokhov wrote:
From: David Lechner <[email protected]>
This suppress printing an error message when pwm_get returns -EPROBE_DEFER.
Otherwise you get a bunch of noise in the kernel log.
Signed-off-by: David Lechner <[email protected]>
Patchwork-Id: 9499915
Signed-off-by: Dmitry Torokhov <[email protected]>
---
drivers/input/misc/pwm-beeper.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
index 04c8ad3827d9..9964c46468d3 100644
--- a/drivers/input/misc/pwm-beeper.c
+++ b/drivers/input/misc/pwm-beeper.c
@@ -108,7 +108,8 @@ static int pwm_beeper_probe(struct platform_device *pdev)
beeper->pwm = devm_pwm_get(dev, NULL);
if (IS_ERR(beeper->pwm)) {
error = PTR_ERR(beeper->pwm);
- dev_err(dev, "Failed to request pwm device: %d\n", error);
+ if (error != -EPROBE_DEFER)
+ dev_err(dev, "Failed to request pwm device\n");
This also drops the error code from the message. I suspect that this was
intentional because failure to probe will print out the error code
anyway. Might be worth mentioning that in the commit message?
Yes, it was intentional for that reason. And in fact we could do the
same thing to the error messages that are touched in patch 2/7 of this
series.
Either way:
Reviewed-by: Thierry Reding <[email protected]>
