* Lee Jones <[email protected]> [170124 01:32]: > On Thu, 05 Jan 2017, Tony Lindgren wrote: > > + > > + bit = irq % cpcap->regmap_conf->val_bits; > > + mask = (1 << bit); > > Nit: BIT() ... > > + * Copyright (C) 2016 Tony Lindgren <[email protected]> > > Nit: 2017 ... > > +/* > > + * Helpers for child devices to check the revision and vendor. > > + * > > + * REVISIT: No documentation for the bits below, please update > > + * to use proper names for defines when available. > > + */ > > Yes, please do that. > > But you can do all of the above with subsequent patches.
OK I'll send you a BIT() follow-up patch. > Applied, thanks. Thanks, not seeing it in next or mfd git tree yet though, forgot to push out? Regards, Tony
