Hi Randy, 2017-01-25 1:40 GMT+09:00 Randy Dunlap <[email protected]>: > From: Randy Dunlap <[email protected]> > > Fix build errors in phy-rockchip-inno-usb2.c. The driver uses > extcon interfaces so it should depend on EXTCON. > > Fixes these build errors: > > drivers/built-in.o: In function `rockchip_usb2phy_otg_sm_work': > phy-rockchip-inno-usb2.c:(.text+0x2bcb): undefined reference to > `extcon_get_state' > phy-rockchip-inno-usb2.c:(.text+0x2cd4): undefined reference to > `extcon_set_state_sync' > phy-rockchip-inno-usb2.c:(.text+0x2cec): undefined reference to > `extcon_set_state_sync' > phy-rockchip-inno-usb2.c:(.text+0x2d2d): undefined reference to > `extcon_get_state' > drivers/built-in.o: In function `rockchip_usb2phy_probe': > phy-rockchip-inno-usb2.c:(.text+0x31d7): undefined reference to > `extcon_get_edev_by_phandle' > phy-rockchip-inno-usb2.c:(.text+0x321a): undefined reference to > `devm_extcon_dev_allocate' > phy-rockchip-inno-usb2.c:(.text+0x3230): undefined reference to > `devm_extcon_dev_register' > phy-rockchip-inno-usb2.c:(.text+0x375a): undefined reference to > `extcon_register_notifier' > > Found in linux-next but is also needed in mainline. > > Signed-off-by: Randy Dunlap <[email protected]> > Cc: MyungJoo Ham <[email protected]> > Cc: Chanwoo Choi <[email protected]> > Cc: Heiko Stuebner <[email protected]> > --- > drivers/phy/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20170124.orig/drivers/phy/Kconfig > +++ linux-next-20170124/drivers/phy/Kconfig > @@ -363,6 +363,7 @@ config PHY_ROCKCHIP_INNO_USB2 > tristate "Rockchip INNO USB2PHY Driver" > depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF > depends on COMMON_CLK > + depends on EXTCON > depends on USB_SUPPORT > select GENERIC_PHY > select USB_COMMON
Looks good to me. You better to send this patch to the phy maintainer (Kishon Vijay Abraham I <[email protected]>). Reviewed-by: Chanwoo Choi <[email protected]> -- Best Regards, Chanwoo Choi Samsung Electronics
