On Fri, 2017-01-27 at 21:31 +0000, Bart Van Assche wrote: > On Fri, 2017-01-27 at 14:15 +0100, Christophe JAILLET wrote: > > > > This test looks reverted. > > We should log an error message only if 'ib_attach_mcast()' fails. > > > > Signed-off-by: Christophe JAILLET <[email protected]> > > --- > > drivers/infiniband/core/cma.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/infiniband/core/cma.c > > b/drivers/infiniband/core/cma.c > > index cfefb941d729..175f62e5841e 100644 > > --- a/drivers/infiniband/core/cma.c > > +++ b/drivers/infiniband/core/cma.c > > @@ -3838,7 +3838,7 @@ static int cma_ib_mc_handler(int status, > > struct ib_sa_multicast *multicast) > > if (!status && id_priv->id.qp) { > > status = ib_attach_mcast(id_priv->id.qp, > > &multicast->rec.mgid, > > be16_to_cpu(multicast- > > >rec.mlid)); > > - if (!status) > > + if (status) > > pr_debug_ratelimited("RDMA CM: > > MULTICAST_ERROR: failed to attach QP. status %d\n", > > status); > > } > > Hello Christophe, > > Do you think this patch needs "Fixes:" and "Cc: stable" tags?
It does not. I already tried to apply it to my 4.10-rc branch and it doesn't apply there. In the for-4.11 queue is a patch to improve debug printouts in the core, and it is that patch that introduced this error. -- Doug Ledford <[email protected]> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
signature.asc
Description: This is a digitally signed message part
