Hi Colin, 2017-02-03 Colin King <[email protected]>:
> From: Colin Ian King <[email protected]> > > If dsi_connector fails to allocate, the exit path via label 'fail' > checks if connector is null, which it always is, so the cleanup > that destroys connector is never going to be called. Hence the > failure path can be more optimally performed by removing this > and just returning ERR_PTR(-ENOMEM). This also removes the need > to initialize connector to NULL, and we can also remove ret too. > > Detected by CoverityScan, CID#1399504 ("Logicall Dead Code") > > Signed-off-by: Colin Ian King <[email protected]> > --- > drivers/gpu/drm/vc4/vc4_dsi.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) Reviewed-by: Gustavo Padovan <[email protected]> Gustavo
