> -----Original Message----- > From: Arnd Bergmann [mailto:[email protected]] > Sent: Tuesday, February 7, 2017 5:00 AM > To: dl-esc-Aacraid Linux Driver <[email protected]>; James E.J. > Bottomley <[email protected]>; Martin K. Petersen > <[email protected]> > Cc: Arnd Bergmann <[email protected]>; Johannes Thumshirn > <[email protected]>; Raghava Aditya Renukunta > <[email protected]>; Dave Carroll > <[email protected]>; [email protected]; linux- > [email protected] > Subject: [PATCH] scsi: aacraid: avoid open-coded upper_32_bits > > EXTERNAL EMAIL > > > Shifting a dma_addr_t right by 32 bits causes a compile-time warning when > that type is only 32 bit wide: > > drivers/scsi/aacraid/src.c: In function 'aac_src_start_adapter': > drivers/scsi/aacraid/src.c:414:29: error: right shift count >= width of type > [- > Werror=shift-count-overflow] > > This changes the driver to use the predefined macros consistently, including > one correct but open-coded upper_32_bits() instance. > > Fixes: d1ef4da8487f ("scsi: aacraid: added support for init_struct_8") > Fixes: 423400e64d37 ("scsi: aacraid: Include HBA direct interface") > Signed-off-by: Arnd Bergmann <[email protected]> > ---
Reviewed-by: Raghava Aditya Renukunta <[email protected]>
