From: Markus Elfring <[email protected]> Date: Tue, 7 Feb 2017 20:06:31 +0100
* The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code places. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring <[email protected]> --- drivers/hid/hid-debug.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c index aafa963e8a04..444c63f0e4be 100644 --- a/drivers/hid/hid-debug.c +++ b/drivers/hid/hid-debug.c @@ -1083,12 +1083,15 @@ static int hid_debug_events_open(struct inode *inode, struct file *file) struct hid_debug_list *list; unsigned long flags; - if (!(list = kzalloc(sizeof(struct hid_debug_list), GFP_KERNEL))) { + list = kzalloc(sizeof(*list), GFP_KERNEL); + if (!list) { err = -ENOMEM; goto out; } - if (!(list->hid_debug_buf = kzalloc(sizeof(char) * HID_DEBUG_BUFSIZE, GFP_KERNEL))) { + list->hid_debug_buf = kzalloc(sizeof(char) * HID_DEBUG_BUFSIZE, + GFP_KERNEL); + if (!list->hid_debug_buf) { err = -ENOMEM; kfree(list); goto out; -- 2.11.1
