Hi Matt, [auto build test ERROR on tip/sched/core] [also build test ERROR on v4.10-rc7 next-20170208] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Matt-Fleming/sched-loadavg-Avoid-loadavg-spikes-caused-by-delayed-NO_HZ-accounting/20170208-224135 config: i386-randconfig-x003-201706 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): kernel/sched/loadavg.c: In function 'calc_load_exit_idle': >> kernel/sched/loadavg.c:404:0: error: unterminated argument list invoking >> macro "if" } >> kernel/sched/loadavg.c:220:2: error: expected '(' at end of input if (time_in_range_open(jiffies, next_window, next_window + 10) ^~ >> kernel/sched/loadavg.c:220:2: warning: this 'if' clause does not guard... >> [-Wmisleading-indentation] kernel/sched/loadavg.c:404:0: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if' } >> kernel/sched/loadavg.c:220:2: error: expected declaration or statement at >> end of input if (time_in_range_open(jiffies, next_window, next_window + 10) ^~ At top level: kernel/sched/loadavg.c:100:1: warning: 'calc_load' defined but not used [-Wunused-function] calc_load(unsigned long load, unsigned long exp, unsigned long active) ^~~~~~~~~ vim +/if +404 kernel/sched/loadavg.c 5ee9e5df kernel/sched/loadavg.c Matt Fleming 2017-02-08 214 * 5ee9e5df kernel/sched/loadavg.c Matt Fleming 2017-02-08 215 * The next window is 'calc_load_update' if we haven't reached it yet, 5ee9e5df kernel/sched/loadavg.c Matt Fleming 2017-02-08 216 * and 'calc_load_update + 10' if we're inside the current window. 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 217 */ 5ee9e5df kernel/sched/loadavg.c Matt Fleming 2017-02-08 218 next_window = calc_load_update; 5ee9e5df kernel/sched/loadavg.c Matt Fleming 2017-02-08 219 5ee9e5df kernel/sched/loadavg.c Matt Fleming 2017-02-08 @220 if (time_in_range_open(jiffies, next_window, next_window + 10) 5ee9e5df kernel/sched/loadavg.c Matt Fleming 2017-02-08 221 next_window += LOAD_FREQ; 5ee9e5df kernel/sched/loadavg.c Matt Fleming 2017-02-08 222 5ee9e5df kernel/sched/loadavg.c Matt Fleming 2017-02-08 223 this_rq->calc_load_update = next_window; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 224 } 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 225 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 226 static long calc_load_fold_idle(void) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 227 { 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 228 int idx = calc_load_read_idx(); 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 229 long delta = 0; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 230 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 231 if (atomic_long_read(&calc_load_idle[idx])) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 232 delta = atomic_long_xchg(&calc_load_idle[idx], 0); 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 233 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 234 return delta; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 235 } 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 236 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 237 /** 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 238 * fixed_power_int - compute: x^n, in O(log n) time 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 239 * 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 240 * @x: base of the power 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 241 * @frac_bits: fractional bits of @x 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 242 * @n: power to raise @x to. 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 243 * 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 244 * By exploiting the relation between the definition of the natural power 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 245 * function: x^n := x*x*...*x (x multiplied by itself for n times), and 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 246 * the binary encoding of numbers used by computers: n := \Sum n_i * 2^i, 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 247 * (where: n_i \elem {0, 1}, the binary vector representing n), 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 248 * we find: x^n := x^(\Sum n_i * 2^i) := \Prod x^(n_i * 2^i), which is 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 249 * of course trivially computable in O(log_2 n), the length of our binary 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 250 * vector. 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 251 */ 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 252 static unsigned long 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 253 fixed_power_int(unsigned long x, unsigned int frac_bits, unsigned int n) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 254 { 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 255 unsigned long result = 1UL << frac_bits; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 256 3289bdb4 kernel/sched/loadavg.c Peter Zijlstra 2015-04-14 257 if (n) { 3289bdb4 kernel/sched/loadavg.c Peter Zijlstra 2015-04-14 258 for (;;) { 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 259 if (n & 1) { 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 260 result *= x; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 261 result += 1UL << (frac_bits - 1); 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 262 result >>= frac_bits; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 263 } 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 264 n >>= 1; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 265 if (!n) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 266 break; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 267 x *= x; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 268 x += 1UL << (frac_bits - 1); 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 269 x >>= frac_bits; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 270 } 3289bdb4 kernel/sched/loadavg.c Peter Zijlstra 2015-04-14 271 } 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 272 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 273 return result; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 274 } 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 275 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 276 /* 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 277 * a1 = a0 * e + a * (1 - e) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 278 * 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 279 * a2 = a1 * e + a * (1 - e) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 280 * = (a0 * e + a * (1 - e)) * e + a * (1 - e) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 281 * = a0 * e^2 + a * (1 - e) * (1 + e) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 282 * 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 283 * a3 = a2 * e + a * (1 - e) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 284 * = (a0 * e^2 + a * (1 - e) * (1 + e)) * e + a * (1 - e) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 285 * = a0 * e^3 + a * (1 - e) * (1 + e + e^2) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 286 * 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 287 * ... 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 288 * 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 289 * an = a0 * e^n + a * (1 - e) * (1 + e + ... + e^n-1) [1] 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 290 * = a0 * e^n + a * (1 - e) * (1 - e^n)/(1 - e) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 291 * = a0 * e^n + a * (1 - e^n) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 292 * 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 293 * [1] application of the geometric series: 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 294 * 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 295 * n 1 - x^(n+1) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 296 * S_n := \Sum x^i = ------------- 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 297 * i=0 1 - x 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 298 */ 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 299 static unsigned long 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 300 calc_load_n(unsigned long load, unsigned long exp, 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 301 unsigned long active, unsigned int n) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 302 { 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 303 return calc_load(load, fixed_power_int(exp, FSHIFT, n), active); 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 304 } 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 305 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 306 /* 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 307 * NO_HZ can leave us missing all per-cpu ticks calling 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 308 * calc_load_account_active(), but since an idle CPU folds its delta into 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 309 * calc_load_tasks_idle per calc_load_account_idle(), all we need to do is fold 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 310 * in the pending idle delta if our idle period crossed a load cycle boundary. 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 311 * 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 312 * Once we've updated the global active value, we need to apply the exponential 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 313 * weights adjusted to the number of cycles missed. 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 314 */ 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 315 static void calc_global_nohz(void) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 316 { 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 317 long delta, active, n; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 318 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 319 if (!time_before(jiffies, calc_load_update + 10)) { 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 320 /* 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 321 * Catch-up, fold however many we are behind still 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 322 */ 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 323 delta = jiffies - calc_load_update - 10; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 324 n = 1 + (delta / LOAD_FREQ); 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 325 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 326 active = atomic_long_read(&calc_load_tasks); 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 327 active = active > 0 ? active * FIXED_1 : 0; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 328 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 329 avenrun[0] = calc_load_n(avenrun[0], EXP_1, active, n); 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 330 avenrun[1] = calc_load_n(avenrun[1], EXP_5, active, n); 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 331 avenrun[2] = calc_load_n(avenrun[2], EXP_15, active, n); 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 332 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 333 calc_load_update += n * LOAD_FREQ; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 334 } 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 335 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 336 /* 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 337 * Flip the idle index... 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 338 * 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 339 * Make sure we first write the new time then flip the index, so that 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 340 * calc_load_write_idx() will see the new time when it reads the new 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 341 * index, this avoids a double flip messing things up. 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 342 */ 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 343 smp_wmb(); 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 344 calc_load_idx++; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 345 } 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 346 #else /* !CONFIG_NO_HZ_COMMON */ 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 347 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 348 static inline long calc_load_fold_idle(void) { return 0; } 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 349 static inline void calc_global_nohz(void) { } 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 350 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 351 #endif /* CONFIG_NO_HZ_COMMON */ 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 352 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 353 /* 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 354 * calc_load - update the avenrun load estimates 10 ticks after the 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 355 * CPUs have updated calc_load_tasks. 3289bdb4 kernel/sched/loadavg.c Peter Zijlstra 2015-04-14 356 * 3289bdb4 kernel/sched/loadavg.c Peter Zijlstra 2015-04-14 357 * Called from the global timer code. 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 358 */ 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 359 void calc_global_load(unsigned long ticks) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 360 { 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 361 long active, delta; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 362 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 363 if (time_before(jiffies, calc_load_update + 10)) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 364 return; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 365 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 366 /* 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 367 * Fold the 'old' idle-delta to include all NO_HZ cpus. 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 368 */ 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 369 delta = calc_load_fold_idle(); 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 370 if (delta) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 371 atomic_long_add(delta, &calc_load_tasks); 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 372 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 373 active = atomic_long_read(&calc_load_tasks); 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 374 active = active > 0 ? active * FIXED_1 : 0; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 375 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 376 avenrun[0] = calc_load(avenrun[0], EXP_1, active); 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 377 avenrun[1] = calc_load(avenrun[1], EXP_5, active); 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 378 avenrun[2] = calc_load(avenrun[2], EXP_15, active); 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 379 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 380 calc_load_update += LOAD_FREQ; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 381 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 382 /* 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 383 * In case we idled for multiple LOAD_FREQ intervals, catch up in bulk. 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 384 */ 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 385 calc_global_nohz(); 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 386 } 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 387 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 388 /* 3289bdb4 kernel/sched/loadavg.c Peter Zijlstra 2015-04-14 389 * Called from scheduler_tick() to periodically update this CPU's 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 390 * active count. 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 391 */ 3289bdb4 kernel/sched/loadavg.c Peter Zijlstra 2015-04-14 392 void calc_global_load_tick(struct rq *this_rq) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 393 { 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 394 long delta; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 395 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 396 if (time_before(jiffies, this_rq->calc_load_update)) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 397 return; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 398 d60585c5 kernel/sched/loadavg.c Thomas Gleixner 2016-07-12 399 delta = calc_load_fold_active(this_rq, 0); 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 400 if (delta) 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 401 atomic_long_add(delta, &calc_load_tasks); 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 402 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 403 this_rq->calc_load_update += LOAD_FREQ; 45ceebf7 kernel/sched/proc.c Paul Gortmaker 2013-04-19 @404 } :::::: The code at line 404 was first introduced by commit :::::: 45ceebf77653975815d82fcf7cec0a164215ae11 sched: Factor out load calculation code from sched/core.c --> sched/proc.c :::::: TO: Paul Gortmaker <[email protected]> :::::: CC: Ingo Molnar <[email protected]> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
