> -----Original Message----- > From: YUAN Linyu [mailto:linyu.y...@alcatel-sbell.com.cn] > Sent: Thursday, February 09, 2017 9:36 AM > To: Salil Mehta; da...@davemloft.net > Cc: Zhuangyuzeng (Yisen); mehta.salil....@gmail.com; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; Linuxarm; > Yankejian (Hackim Yim) > Subject: RE: [PATCH net] net: hns: Fix the device being used for dma > mapping during TX > > > > > -----Original Message----- > > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] > > On Behalf Of Salil Mehta > > Sent: Thursday, February 09, 2017 5:24 PM > > To: da...@davemloft.net > > Cc: salil.me...@huawei.com; yisen.zhu...@huawei.com; > > mehta.salil....@gmail.com; net...@vger.kernel.org; > > linux-kernel@vger.kernel.org; linux...@huawei.com; Kejian Yan > > Subject: [PATCH net] net: hns: Fix the device being used for dma > mapping during > > TX > > > > From: Kejian Yan <yankej...@huawei.com> > > > > This patch fixes the device being used to DMA map skb->data. > > Erroneous device assignment causes the crash when SMMU is enabled. > > This happens during TX since buffer gets DMA mapped with device > > correspondign to net_device and gets unmapped using the device > > related to DSAF. > > > > Signed-off-by: Kejian Yan <yankej...@huawei.com> > > Reviewed-by: Yisen Zhuang <yisen.zhu...@huawei.com> > > Signed-off-by: Salil Mehta <salil.me...@huawei.com> > > --- > > drivers/net/ethernet/hisilicon/hns/hns_enet.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c > > b/drivers/net/ethernet/hisilicon/hns/hns_enet.c > > index 672b646..2b52a12 100644 > > --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c > > +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c > > @@ -305,7 +305,7 @@ int hns_nic_net_xmit_hw(struct net_device *ndev, > > struct hns_nic_ring_data *ring_data) > > { > > struct hns_nic_priv *priv = netdev_priv(ndev); > > - struct device *dev = priv->dev; > > + struct device *dev = ring_to_dev(ring_data->ring); > > struct hnae_ring *ring = ring_data->ring; > struct device *dev = ring_to_dev(ring); ?????? Yes, name of the macro is slight misnomer but this gets the dsaf device. Hope this answers your question?
Thanks Salil > > struct netdev_queue *dev_queue; > > struct skb_frag_struct *frag; > > -- > > 1.7.9.5 > >
