Although llist provides proper APIs, they are not used. Make them used.

Signed-off-by: Byungchul Park <byungchul.p...@lge.com>
---
 drivers/md/bcache/closure.c | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c
index 864e673..1841d03 100644
--- a/drivers/md/bcache/closure.c
+++ b/drivers/md/bcache/closure.c
@@ -64,27 +64,16 @@ void closure_put(struct closure *cl)
 void __closure_wake_up(struct closure_waitlist *wait_list)
 {
        struct llist_node *list;
-       struct closure *cl;
+       struct closure *cl, *t;
        struct llist_node *reverse = NULL;
 
        list = llist_del_all(&wait_list->list);
 
        /* We first reverse the list to preserve FIFO ordering and fairness */
-
-       while (list) {
-               struct llist_node *t = list;
-               list = llist_next(list);
-
-               t->next = reverse;
-               reverse = t;
-       }
+       reverse = llist_reverse_order(list);
 
        /* Then do the wakeups */
-
-       while (reverse) {
-               cl = container_of(reverse, struct closure, list);
-               reverse = llist_next(reverse);
-
+       llist_for_each_entry_safe(cl, t, reverse, list) {
                closure_set_waiting(cl, 0);
                closure_sub(cl, CLOSURE_WAITING + 1);
        }
-- 
1.9.1

Reply via email to