> -----Original Message----- > From: Jiri Slaby [mailto:jsl...@suse.cz] > Sent: Wednesday, February 15, 2017 11:04 AM > To: Kershner, David A <david.kersh...@unisys.com> > Cc: linux-kernel@vger.kernel.org; Stefan Svinciak <xsvi...@fi.muni.cz>; Jiri > Slaby <jsl...@suse.cz>; Greg Kroah-Hartman > <gre...@linuxfoundation.org>; *S-Par-Maintainer > <sparmaintai...@unisys.com>; de...@driverdev.osuosl.org > Subject: [PATCH] staging: visorbus, replace init_timer with setup_timer > > From: Stefan Svinciak <xsvi...@fi.muni.cz> > > Newer version is more readable and needs less changes if/when > timer_struct is to be changed. > > Signed-off-by: Stefan Svinciak <xsvi...@fi.muni.cz> > Signed-off-by: Jiri Slaby <jsl...@suse.cz> > Cc: David Kershner <david.kersh...@unisys.com> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: <sparmaintai...@unisys.com> > Cc: <de...@driverdev.osuosl.org>
Acked-by: David Kershner <david.kersh...@unisys.com> Looks good and runs nicely on s-Par. David Kershner > --- > drivers/staging/unisys/visorbus/visorbus_main.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c > b/drivers/staging/unisys/visorbus/visorbus_main.c > index aea1aa262b28..55f29ae8e015 100644 > --- a/drivers/staging/unisys/visorbus/visorbus_main.c > +++ b/drivers/staging/unisys/visorbus/visorbus_main.c > @@ -623,9 +623,7 @@ create_visor_device(struct visor_device *dev) > dev->device.release = visorbus_release_device; > /* keep a reference just for us (now 2) */ > get_device(&dev->device); > - init_timer(&dev->timer); > - dev->timer.data = (unsigned long)(dev); > - dev->timer.function = dev_periodic_work; > + setup_timer(&dev->timer, dev_periodic_work, (unsigned long)dev); > > /* > * bus_id must be a unique name with respect to this bus TYPE > -- > 2.11.1
