On Thu, Mar 02, 2017 at 09:05:57PM +0530, Arushi Singhal wrote: > Placed Logical continuations on the previous line as reported by > checkpatch.pl. > > Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
Hi Arushi, I'm not seeing the patch cover letter for this one. That would be your [PATCH 0/4] and would come first and then 1 through 4 follow threaded as your've done. Stating in imperative might look like this: place logical continuation on previous line insert spaces around operator use tabs for indentation align open parenthesis I didn't look into the changes themselves. alisons > --- > drivers/staging/speakup/main.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c > index a12ec2b061fe..25acebb9311f 100644 > --- a/drivers/staging/speakup/main.c > +++ b/drivers/staging/speakup/main.c > @@ -2144,10 +2144,10 @@ speakup_key(struct vc_data *vc, int shift_state, int > keycode, u_short keysym, > if (up_flag || spk_killed || type == KT_SHIFT) > goto out; > spk_shut_up &= 0xfe; > - kh = (value == KVAL(K_DOWN)) > - || (value == KVAL(K_UP)) > - || (value == KVAL(K_LEFT)) > - || (value == KVAL(K_RIGHT)); > + kh = (value == KVAL(K_DOWN)) || > + (value == KVAL(K_UP)) || > + (value == KVAL(K_LEFT)) || > + (value == KVAL(K_RIGHT)); > if ((cursor_track != read_all_mode) || !kh) > if (!spk_no_intr) > spk_do_flush(); > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscr...@googlegroups.com. > To post to this group, send email to outreachy-ker...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/20170302153600.13803-1-arushisinghal19971997%40gmail.com. > For more options, visit https://groups.google.com/d/optout.
