On 15.03.17 18:46:22, Marc Zyngier wrote: > On 15/03/17 18:37, Robert Richter wrote: > > On 14.03.17 12:40:45, Shanker Donthineni wrote:
> >>> @@ -1698,6 +1706,9 @@ static int __init its_init_one(struct its_node *its) > >>> return err; > >>> } > >>> > >>> + /* Setup dma_ops for dmam_alloc_coherent() */ > >>> + arch_setup_dma_ops(&its->dev, 0, 0, NULL, true); > >>> + > > > >> Why you are hard-coding DMA coherent property to true here ? It > >> breaks the MSI(x) functionally on systems where ITS hardware doesn't > >> support coherency. > > > > Aren't current ITS tables coherent only? > > No, there is no such guarantee. Actually, there is strictly no need for > coherency, as the ITS tables are only written by the ITS itself, for its > own purpose. So no need to change that, right? Thanks, -Robert
