On Thu, Mar 16, 2017 at 05:41:36PM -0700, Kuppuswamy Sathyanarayanan wrote:
> This patch removes the unused iTCO GCR memory resource
>

Looks fine to me.
 
> Signed-off-by: Kuppuswamy Sathyanarayanan 
> <sathyanarayanan.kuppusw...@linux.intel.com>
> ---
>  drivers/platform/x86/intel_pmc_ipc.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel_pmc_ipc.c 
> b/drivers/platform/x86/intel_pmc_ipc.c
> index 12018f3..e9e1d62 100644
> --- a/drivers/platform/x86/intel_pmc_ipc.c
> +++ b/drivers/platform/x86/intel_pmc_ipc.c
> @@ -126,7 +126,6 @@ static struct intel_pmc_ipc_dev {
>       struct platform_device *tco_dev;
>  
>       /* gcr */
> -     resource_size_t gcr_base;
>       void __iomem *gcr_mem_base;
>       int gcr_size;
>       bool has_gcr_regs;
> @@ -529,10 +528,6 @@ static struct resource tco_res[] = {
>       {
>               .flags = IORESOURCE_IO,
>       },
> -     /* GCS */
> -     {
> -             .flags = IORESOURCE_MEM,
> -     },
>  };
>  
>  static struct itco_wdt_platform_data tco_info = {
> @@ -594,10 +589,6 @@ static int ipc_create_tco_device(void)
>       res->start = ipcdev.acpi_io_base + SMI_EN_OFFSET;
>       res->end = res->start + SMI_EN_SIZE - 1;
>  
> -     res = tco_res + TCO_RESOURCE_GCR_MEM;
> -     res->start = ipcdev.gcr_base + TCO_PMC_OFFSET;
> -     res->end = res->start + TCO_PMC_SIZE - 1;
> -
>       pdev = platform_device_register_full(&pdevinfo);
>       if (IS_ERR(pdev))
>               return PTR_ERR(pdev);
> @@ -759,7 +750,6 @@ static int ipc_plat_get_res(struct platform_device *pdev)
>       }
>       ipcdev.ipc_base = addr;
>  
> -     ipcdev.gcr_base = res->start + PLAT_RESOURCE_GCR_OFFSET;
>       ipcdev.gcr_mem_base = addr + PLAT_RESOURCE_GCR_OFFSET;
>       ipcdev.gcr_size = PLAT_RESOURCE_GCR_SIZE;
>       dev_info(&pdev->dev, "ipc res: %pR\n", res);
> -- 
> 2.7.4
> 

-- 
Best Regards,
Rajneesh

Reply via email to