On 15/03/17 04:44, Javier Martinez Canillas wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
>
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
>
> Signed-off-by: Javier Martinez Canillas <[email protected]>
Applied.
Jonathan
> ---
>
> drivers/iio/light/us5182d.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/iio/light/us5182d.c b/drivers/iio/light/us5182d.c
> index 18cf2e29e4d5..d571ad7291ed 100644
> --- a/drivers/iio/light/us5182d.c
> +++ b/drivers/iio/light/us5182d.c
> @@ -972,10 +972,17 @@ static const struct i2c_device_id us5182d_id[] = {
>
> MODULE_DEVICE_TABLE(i2c, us5182d_id);
>
> +static const struct of_device_id us5182d_of_match[] = {
> + { .compatible = "upisemi,usd5182" },
> + {}
> +};
> +MODULE_DEVICE_TABLE(of, us5182d_of_match);
> +
> static struct i2c_driver us5182d_driver = {
> .driver = {
> .name = US5182D_DRV_NAME,
> .pm = &us5182d_pm_ops,
> + .of_match_table = us5182d_of_match,
> .acpi_match_table = ACPI_PTR(us5182d_acpi_match),
> },
> .probe = us5182d_probe,
>
