On Sat, Mar 18, 2017 at 05:09:27PM -0400, Steven Rostedt wrote: > @@ -111,12 +114,11 @@ GLOBAL(ftrace_regs_call) > popl %es > popl %fs > popl %gs > - addl $8, %esp /* Skip orig_ax and ip */ > - popf /* Pop flags at end (no addl to > corrupt flags) */ > - jmp .Lftrace_ret > > - popf > - jmp ftrace_stub > + /* use lea to not affect flags */ > + lea 3*4(%esp), %esp /* Skip orig_ax, ip and flags */ > + > + jmp .Lftrace_ret > #else /* ! CONFIG_DYNAMIC_FTRACE */ > > ENTRY(mcount)
That last comment should be /* Skip orig_ax, ip and cs */ Otherwise: Reviewed-by: Josh Poimboeuf <[email protected]> -- Josh
