> -----Original Message----- > From: David Miller [mailto:[email protected]] > Sent: Friday, March 31, 2017 4:03 AM > To: Salil Mehta > Cc: Zhuangyuzeng (Yisen); [email protected]; > [email protected]; [email protected]; Linuxarm > Subject: Re: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code > Improvements > > From: Salil Mehta <[email protected]> > Date: Thu, 30 Mar 2017 16:30:47 +0100 > > > This patch set introduces various HNS bug fixes, optimizations and > code > > improvements. > > There is no way you should do such an expensive calculation for every > single transmit packet as you are doing in your select_queue() routine. > > That's really crazy. > > Just use the networking stack's queue selection scheme, or suggest > ways to improve it. Don't do private hashing like this in your > driver, please! Hi David, I got your point. I will drop this patch from this patch-set for now.
Thanks Salil
