On 31/03/2017 at 17:22:47 +0200, Ludovic Desroches wrote: > From: Ludovic Desroches <[email protected]>
I think you probably want to switch to your microchip email. Also, this requires a proper commit message. > > Signed-off-by: Ludovic Desroches <[email protected]> > +struct atmel_ptc { > + void __iomem *ppp_regs; > + void __iomem *firmware; > + int irq; > + uint8_t imr; > + volatile struct atmel_qtm_mailbox __iomem *qtm_mb; > + struct clk *clk_per; > + struct clk *clk_int_osc; > + struct clk *clk_slow; > + struct device *dev; > + struct completion ppp_ack; > + unsigned int button_keycode[ATMEL_PTC_MAX_NODES]; > + struct input_dev *buttons_input; > + struct input_dev *scroller_input[ATMEL_PTC_MAX_SCROLLERS]; > + bool buttons_registered; > + bool scroller_registered[ATMEL_PTC_MAX_SCROLLERS]; > + uint32_t button_event[ATMEL_PTC_MAX_NODES/32]; > + uint32_t button_state[ATMEL_PTC_MAX_NODES/32]; > + uint32_t scroller_event; > + uint32_t scroller_state; You should use u8, u16 and u32 instead of uint8_t, uint16_t and uint32_t. > diff --git a/include/uapi/linux/atmel_ptc.h b/include/uapi/linux/atmel_ptc.h > new file mode 100644 > index 0000000..d15c4df > --- /dev/null > +++ b/include/uapi/linux/atmel_ptc.h Is there any sample application showing how to configure the PTC? -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
