In the code dumping ETB buffer is terminated when read back value 0xFFFF_FFFF. This is not safe and introduce infinite looping for some cases, e.g. when reset the CPU and read out ETB RAM.
Cc: Mathieu Poirier <[email protected]> Cc: Mike Leach <[email protected]> Cc: Suzuki K Poulose <[email protected]> Signed-off-by: Leo Yan <[email protected]> --- drivers/hwtracing/coresight/coresight-tmc-etf.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/hwtracing/coresight/coresight-tmc-etf.c b/drivers/hwtracing/coresight/coresight-tmc-etf.c index 3a1c181..6150dac 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-etf.c +++ b/drivers/hwtracing/coresight/coresight-tmc-etf.c @@ -54,6 +54,13 @@ static void tmc_etb_dump_hw(struct tmc_drvdata *drvdata) read_data = readl_relaxed(drvdata->base + TMC_RRD); if (read_data == 0xFFFFFFFF) return; + + /* Check if allocated buffer is overflow */ + if (drvdata->len >= drvdata->size) { + dev_info(drvdata->dev, "TMC dump overflow!\n"); + return; + } + memcpy(bufp, &read_data, 4); bufp += 4; drvdata->len += 4; -- 2.7.4
