El Tue, Apr 04, 2017 at 11:07:20AM -0700 Matthias Kaehlcke ha dit: > From: Mark Charlebois <[email protected]> > > cmd in COMPATIBLE_IOCTL is always a u32, so cast it so there isn't a > warning about an overflow in XFORM. > > From: Mark Charlebois <[email protected]> > Signed-off-by: Mark Charlebois <[email protected]> > Signed-off-by: Behan Webster <[email protected]> > Signed-off-by: Matthias Kaehlcke <[email protected]> > Acked-by: Arnd Bergmann <[email protected]> > --- > Resending https://patchwork.kernel.org/patch/4961631/ > > fs/compat_ioctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c > index 11d087b2b28e..6116d5275a3e 100644 > --- a/fs/compat_ioctl.c > +++ b/fs/compat_ioctl.c > @@ -833,7 +833,7 @@ static int compat_ioctl_preallocate(struct file *file, > */ > #define XFORM(i) (((i) ^ ((i) << 27) ^ ((i) << 17)) & 0xffffffff) > > -#define COMPATIBLE_IOCTL(cmd) XFORM(cmd), > +#define COMPATIBLE_IOCTL(cmd) XFORM((u32)cmd), > /* ioctl should not be warned about even if it's not implemented. > Valid reasons to use this: > - It is implemented with ->compat_ioctl on some device, but programs
Ping, any feedback on this change? Thanks Matthias
