On Wed, Apr 19, 2017 at 03:59:05PM -0400, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/pinctrl/Kconfig:config PINCTRL_ARTPEC6 > drivers/pinctrl/Kconfig: bool "Axis ARTPEC-6 pin controller driver" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments.
Agreed, building as module is useless for this central pin controller. Acked-by: Jesper Nilsson <[email protected]> > Cc: Lars Persson <[email protected]> > Cc: Niklas Cassel <[email protected]> > Cc: Linus Walleij <[email protected]> > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Paul Gortmaker <[email protected]> > --- > drivers/pinctrl/pinctrl-artpec6.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-artpec6.c > b/drivers/pinctrl/pinctrl-artpec6.c > index b5a2eff7ae3d..2886e77fbcf0 100644 > --- a/drivers/pinctrl/pinctrl-artpec6.c > +++ b/drivers/pinctrl/pinctrl-artpec6.c > @@ -12,7 +12,6 @@ > #include <linux/err.h> > #include <linux/init.h> > #include <linux/io.h> > -#include <linux/module.h> > #include <linux/of.h> > #include <linux/platform_device.h> > #include <linux/pinctrl/pinctrl.h> > @@ -979,14 +978,3 @@ static int __init artpec6_pmx_init(void) > return platform_driver_register(&artpec6_pmx_driver); > } > arch_initcall(artpec6_pmx_init); > - > -static void __exit artpec6_pmx_exit(void) > -{ > - platform_driver_unregister(&artpec6_pmx_driver); > -} > -module_exit(artpec6_pmx_exit); > - > -MODULE_AUTHOR("Chris Paterson <[email protected]>"); > -MODULE_DESCRIPTION("Axis ARTPEC-6 pin control driver"); > -MODULE_LICENSE("GPL v2"); > -MODULE_DEVICE_TABLE(of, artpec6_pinctrl_match); > -- > 2.11.0 /^JN - Jesper Nilsson -- Jesper Nilsson -- [email protected]
