On Thu, 20 Apr 2017, Thomas Gleixner wrote:
On Wed, 19 Apr 2017, Vikas Shivappa wrote:
Schemata is displayed in tabular format which introduces some whitespace
to show data in a tabular format. If user wants to input the same data
that is displayed, the parsing fails. Trim the leading and trailing
whitespace to help parse such data.
Reported-by: Prakhya, Sai Praneeth <sai.praneeth.prak...@intel.com>
Signed-off-by: Vikas Shivappa <vikas.shiva...@linux.intel.com>
Tested-by: Prakhya, Sai Praneeth <sai.praneeth.prak...@intel.com>
---
arch/x86/kernel/cpu/intel_rdt_schemata.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/intel_rdt_schemata.c
b/arch/x86/kernel/cpu/intel_rdt_schemata.c
index 9467a00..3cfa1ca 100644
--- a/arch/x86/kernel/cpu/intel_rdt_schemata.c
+++ b/arch/x86/kernel/cpu/intel_rdt_schemata.c
@@ -143,7 +143,7 @@ static int parse_line(char *line, struct rdt_resource *r)
return -EINVAL;
list_for_each_entry(d, &r->domains, list) {
if (d->id == dom_id) {
- if (r->parse_ctrlval(dom, r, d))
+ if (r->parse_ctrlval(strim(dom), r, d))
return -EINVAL;
goto next;
}
@@ -220,7 +220,7 @@ ssize_t rdtgroup_schemata_write(struct kernfs_open_file *of,
goto out;
}
for_each_enabled_rdt_resource(r) {
- if (!strcmp(resname, r->name) &&
+ if (!strcmp(strim(resname), r->name) &&
Both strims() invocations are just silly. They can be done before the loop
once instead of doing them over and over again.
Will fix. I went overboard not wanting to add a line
Thanks,
Vikas
Thanks,
tglx
