On 04/23/2017 03:33 AM, Leon Romanovsky wrote:
On Sat, Apr 22, 2017 at 04:36:19PM +0200, SF Markus Elfring wrote:
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sat, 22 Apr 2017 13:26:49 +0200
Replace the specification of data types by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determinations a bit safer according to the Linux coding style convention.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
---
v2:
Changes were rebased on source files from Linux next-20170421.
These were recombined as requested by Doug Ledford.
Hi Doug,
I recommend you to be extra cautious with this blind automatic
conversions. It requires inspection that every size before and after
match each other.
I already asked it and would be like to repeat it. Please DON'T take any
patches from Markus, which are related to mlx4/mlx5/rxe without our explicit
review of them.
I agree with Leon here, and these sort of find/replace automagic
clean-up patches make me nervous sometimes.
Markus, what have you done to ensure your patches don't break anything?
-Denny
