From: Markus Elfring <[email protected]> Date: Mon, 24 Apr 2017 19:45:25 +0200
The script "checkpatch.pl" pointed information out like the following. WARNING: Possible unnecessary 'out of memory' message Thus remove such statements here. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring <[email protected]> --- drivers/hid/hid-sensor-hub.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c index 349494fc8def..feb4bb8ee3ec 100644 --- a/drivers/hid/hid-sensor-hub.c +++ b/drivers/hid/hid-sensor-hub.c @@ -640,10 +640,8 @@ static int sensor_hub_probe(struct hid_device *hdev, struct hid_sensor_hub_device *collection_hsdev = NULL; sd = devm_kzalloc(&hdev->dev, sizeof(*sd), GFP_KERNEL); - if (!sd) { - hid_err(hdev, "cannot allocate Sensor data\n"); + if (!sd) return -ENOMEM; - } hid_set_drvdata(hdev, sd); sd->quirks = id->driver_data; @@ -678,7 +676,6 @@ static int sensor_hub_probe(struct hid_device *hdev, sizeof(*sd->hid_sensor_hub_client_devs), GFP_KERNEL); if (sd->hid_sensor_hub_client_devs == NULL) { - hid_err(hdev, "Failed to allocate memory for mfd cells\n"); ret = -ENOMEM; goto err_stop_hw; } @@ -692,7 +689,6 @@ static int sensor_hub_probe(struct hid_device *hdev, hsdev = devm_kzalloc(&hdev->dev, sizeof(*hsdev), GFP_KERNEL); if (!hsdev) { - hid_err(hdev, "cannot allocate hid_sensor_hub_device\n"); ret = -ENOMEM; goto err_stop_hw; } -- 2.12.2
