On Tue 25-04-17 15:33:29, Florian Fainelli wrote:
> If the caller has set __GFP_NOWARN don't print the following message:
> vmap allocation for size 15736832 failed: use vmalloc=<size> to increase
> size.
>
> This can happen with the ARM/Linux module loader built with
> CONFIG_ARM_MODULE_PLTS=y which does a first attempt at loading a large
> module from module space, then falls back to vmalloc space.
>
> Signed-off-by: Florian Fainelli <f.faine...@gmail.com>
> ---
> mm/vmalloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 0b057628a7ba..5a788eb58741 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -521,7 +521,7 @@ static struct vmap_area *alloc_vmap_area(unsigned long
> size,
> }
> }
>
> - if (printk_ratelimit())
> + if (printk_ratelimit() && !(gfp_mask & __GFP_NOWARN))
Are you sure about this ordering? Should NOWARN requests alter the
ratelimit state?
> pr_warn("vmap allocation for size %lu failed: use
> vmalloc=<size> to increase size\n",
> size);
> kfree(va);
> --
> 2.9.3
>
--
Michal Hocko
SUSE Labs
