On Tue, May 2, 2017 at 7:14 PM, Anatolij Gustschin <ag...@denx.de> wrote: > On Wed, 3 May 2017 00:28:17 +0300 > Andy Shevchenko andy.shevche...@gmail.com wrote: > ... >>>>Is 0xff a mask here? (Btw, you missed spaces around <<) >>> >>> yes, it is. Will add spaces (checkpatch didn't warn here). >> >>Then it makes sense to add _MASK and use GENMASK() instead of direct value. > > ok, will do. > >>>>Why do we need that?! >>>>In new drivers we try to avoid new module parameters. We have enough >>>>interfaces nowadays to let driver know some details (quirks). >>> >>> Which interface is preffered here? Do you suggest sysfs? Won't be able >>> to pass the parameter on kernel command line, then. >> >>Yes, my question here is to understand what so important that driver >>needs module parameter. >>Can you elaborate? > > the driver doesn't need this parameter, but it could help testing > the loading of compressed or encrypted images.
Loading encrypted or compressed images can be keyed off of flags in fpga_image_info. Currently we have FPGA_MGR_ENCRYPTED_BITSTREAM Will need to add one for compressed such as FPGA_MGR_COMPRESSED_BITSTREAM Alan
