On Thursday, May 4, 2017 4:58:15 PM CEST Jin Yao wrote:
> The annotate browser is divided into 2 frames. Left frame
> contains 3 columns (some platforms only have one column).
>
> For example:
>
> │26 int compute_flag()
> │27 {
> 22.80 1.20 │ sub $0x8,%rsp
> │25 int i;
> │
> │27 i = rand() % 2;
> 22.78 1.20 1 │ → callq rand@plt
>
> While it's hard for user to understand what the data is.
>
> This patch adds the titles "Percent", "IPC" and "Cycle"
> on columns.
>
> Percnt IPC Cycle │
> │25 __attribute__((noinline))
> │26 int compute_flag()
> │27 {
> 22.80 1.20 │ sub $0x8,%rsp
> │25 int i;
> │
> │27 i = rand() % 2;
> 22.78 1.20 1 │ → callq rand@plt
>
> The titles are displayed at row 0 of annotate browser if row 0
> doesn't have values of percent, ipc and cycle.
Functionality wise a really good improvement - thanks! But personally I find
the abbreviation of one character (i.e. "Percnt" instead of "Percent") not so
nice. If space really is an issue here, use "%"?
Also note though that it's unclear what this percentage actually is. I guess
it's a sample percentage? Maybe a header should be added that explains these
values to newbies. I bet many people won't even know what IPC is either.
Cheers
--
Milian Wolff | milian.wo...@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
