On Fri, 2017-05-05 at 09:33 -0700, Linus Torvalds wrote: > On Fri, May 5, 2017 at 9:00 AM, James Bottomley > <[email protected]> wrote: > > > > I'm not going to defend the earlier coding, but you've lost the > > real device_add() calls in the merge, meaning the tpm devices don't > > actually get made visible at all. I suspect assuming device_add() > > is done by cdev_device_add() because of the name is going to be our > > next anti-pattern, so you're at least ahead of the game ... > > Don't be silly. That's *exactly* what cdev_device_add() does.
Oh, you're right, sorry, I was going by the patches that were cc'd to the TPM list, which only had the two line addition for cdev_device_add() ... apparently no-one sent any updates. Yes, the new function looks much better and the resolution works. Sorry for the noise. James
