Hi Rob, On Mon, May 8, 2017 at 6:55 PM, Rob Herring <[email protected]> wrote: > On Thu, May 04, 2017 at 07:45:46PM +0200, Geert Uytterhoeven wrote: >> Signed-off-by: Geert Uytterhoeven <[email protected]> >> --- >> v3: >> - In SPI slave mode, represent the (single) slave device again as a >> child of the controller node, which is now optional, and must be >> named "slave" if present, >> - Split slave node properties in master mode, slave mode, and common >> properties, >> >> v2: >> - Do not create a child node in SPI slave mode. Instead, add an >> "spi-slave" property, and put the mode properties in the controller >> node.
>> --- a/Documentation/devicetree/bindings/spi/spi-bus.txt >> +++ b/Documentation/devicetree/bindings/spi/spi-bus.txt >> +In slave mode, the SPI controller node requires one additional property: >> +- spi-slave - Empty property. > > Do we still need this if we have a child node called "slave". Yes, as the child node called "slave" is optional. In that case, configuration of the slave protocol is done through sysfs, but that is Linux-specific and thus doesn't belong in the DT bindings. > Otherwise, > > Reviewed-by: Rob Herring <[email protected]> Thank you! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
