On Tue, 16 May 2017 23:21:25 +0530 "Naveen N. Rao" <[email protected]> wrote:
> Handle a NULL glob properly and simplify the check. > Looks good to me. Reviewed-by: Masami Hiramatsu <[email protected]> Thanks! > Signed-off-by: Naveen N. Rao <[email protected]> > --- > kernel/trace/ftrace.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > index 39dca4e86a94..c35c3e67d09a 100644 > --- a/kernel/trace/ftrace.c > +++ b/kernel/trace/ftrace.c > @@ -4144,9 +4144,9 @@ unregister_ftrace_function_probe_func(char *glob, > struct trace_array *tr, > int i, ret = -ENODEV; > int size; > > - if (glob && (strcmp(glob, "*") == 0 || !strlen(glob))) > + if (!glob || !strlen(glob) || !strcmp(glob, "*")) > func_g.search = NULL; > - else if (glob) { > + else { > int not; > > func_g.type = filter_parse_regex(glob, strlen(glob), > -- > 2.12.2 > -- Masami Hiramatsu <[email protected]>
