On Thu, May 18, 2017 at 5:39 PM, Mika Westerberg
<[email protected]> wrote:
> The device DROM contains name of the vendor and device among other
> things. Extract this information and expose it to the userspace via two
> new attributes.
One nit below.
> + switch (header->type) {
> + case TB_DROM_ENTRY_PORT:
> + break;
> + case TB_DROM_ENTRY_GENERIC:
> + tb_drom_parse_generic_entry(sw,
> + (struct tb_drom_entry_generic *)header);
Can it be one line?
Is fall through intended?
> + default:
> return 0;
> + }
--
With Best Regards,
Andy Shevchenko