On Wed, May 17, 2017 at 9:37 AM, Nicolas Iooss <[email protected]> wrote: > Hello, > > The patch I sent a few months ago still applies cleanly on top of > 4.12-rc1. What should I do in order to get it merged in 4.13? > > In case you no longer have my initial email, the patch has been > archived in https://patchwork.kernel.org/patch/9604651/ .
Avoid top postings, please. Looking into patch I see the following 1) the constify part is better to be a separate patch; 2) shouldn't be specifier '%ju' applied? >>>> Isn't "(u64)" shorter to write? >>> >>> u64 does not seem to be defined in this file right now. Adding >>> "#include <linux/types.h>" defines u64 and __u64 in the following way: >>> - "typedef uint64_t u64;" from tools/include/linux/types.h >>> - "typedef unsigned long long __u64;" from >>> /usr/include/asm-generic/int-ll64.h >>> >>> uint64_t is unsigned long on x86-64 and gcc complains when using %llu >>> on such a type, so using a cast to u64 forces using PRIu64 too. -- With Best Regards, Andy Shevchenko
