On Sun, May 28, 2017 at 10:11:18AM +0300, Alex A. Mihaylov wrote:

> +     int ret = -ENODEV;
> +
> +     mutex_lock(&sl->master->bus_mutex);
> +     if (!w1_reset_select_slave(sl)) {
> +             w1_write_8(sl->master, W1_CMD_READ_DATA);
> +             w1_write_8(sl->master, reg);
> +             *val = w1_read_8(sl->master);
> +             ret = 0;
> +     }

I asked you to move the error handling into the else case in these :(

Attachment: signature.asc
Description: PGP signature

Reply via email to