On Thu, May 25, 2017 at 11:58:37AM +0800, Chen-Yu Tsai wrote: > On Wed, May 24, 2017 at 6:06 PM, Icenowy Zheng <[email protected]> wrote: > > From: Icenowy Zheng <[email protected]> > > > > The V3s SoC features an analog codec with headphone support but without > > mic2 and linein. > > > > Add support for it. > > > > Signed-off-by: Icenowy Zheng <[email protected]> > > Reviewed-by: Chen-Yu Tsai <[email protected]> > > Mark, please hold off on applying this patch until the comments from the > previous patch have been addressed. They should be applied in order. > > > --- > > Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt | 1 + > > sound/soc/sunxi/sun8i-codec-analog.c | 9 > > +++++++++ > > Also, is there a preference for splitting out device tree binding > changes from driver changes?
Yes, but not necessary for a 1 line change. Rob
