On Fri, Jun 02, 2017 at 10:52:24AM +0800, Du, Changbin wrote: > On Thu, Jun 01, 2017 at 12:21:39PM +0200, Jiri Olsa wrote: > > On Thu, Jun 01, 2017 at 05:03:21PM +0800, [email protected] wrote: > > > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c > > > index 5762ae4..69eea3a 100644 > > > --- a/tools/perf/util/sort.c > > > +++ b/tools/perf/util/sort.c > > > @@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys) > > > if (sort__mode == SORT_MODE__DIFF) > > > return keys; > > > > > > + if (strstr(keys, "overhead")) > > > + return keys; > > > + > > > keys = prefix_if_not_in("overhead", keys); > > > > hum, you basicaly do what's at begining of prefix_if_not_in function: > > > > static char *prefix_if_not_in(const char *pre, char *str) > > { > > char *n; > > > > if (!str || strstr(str, pre)) > > return str; > > ... > > > Thanks, will change it. > Misunderstood your words. This is not equal to prefix_if_not_in. # perf record -ag # perf report -s overhead,sym
Samples: 7K of event 'cycles', Event count (approx.): 865138253 Children Self Symbol + 26.41% 0.00% [k] verify_cpu + 26.37% 0.04% [k] cpu_startup_entry + 25.93% 0.27% [k] do_idle + 19.88% 0.00% [k] start_secondary .... 'Children' should not be here. > > > > could you please provide the example described in changelog? > > > Will add example cmdline there, Thanks. > > > jirka > > -- > Thanks, > Changbin Du -- Thanks, Changbin Du
signature.asc
Description: PGP signature
