On Thu, Jun 8, 2017 at 8:35 AM, Arnaldo Carvalho de Melo <[email protected]> wrote: > Em Tue, May 30, 2017 at 08:18:26PM +0900, SeongJae Park escreveu: >> This commit fixes wrong code snippets for trace_begin() and trace_end() >> function example definition. > > Fixed, and using: > > git log --follow tools/perf/Documentation/perf-script-python.txt > > Added the Fixes: tag: > > Fixes: cff68e582237 ("perf/scripts: Add perf-trace-python Documentation") > > And since you're taking the time to add the Fixes tag (yay, great!) > please also add Cc: entries for the patch author and committer, in that > case:
Ok, I will do that from next time. > > Cc: Tom Zanussi <[email protected]> > Cc: Frederic Weisbecker <[email protected]> > > I did it this time, using a script I have: > > [acme@jouet linux]$ cat ~/bin/fixes > #!/bin/bash > > cset=$1 > if [ $# -eq 0 ] ; then > read cset > fi > git show --pretty=fuller $cset | grep '^\(Author\|Commit\): ' | sed -r 's/.*: > +/Cc: /g' > echo Fixes: `git one $cset` > [acme@jouet linux]$ > > Just get the cset, in vim, and select it, pressing Shift+V while the > cursor is on top of the cset id and then press : and finally !fixes + > ENTER :) > > cff68e582237 So sweet script! :D Thanks, SeongJae Park > > - Arnaldo > >> Signed-off-by: SeongJae Park <[email protected]> >> --- >> tools/perf/Documentation/perf-script-python.txt | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/tools/perf/Documentation/perf-script-python.txt >> b/tools/perf/Documentation/perf-script-python.txt >> index 44e51351536f..f723ce41268c 100644 >> --- a/tools/perf/Documentation/perf-script-python.txt >> +++ b/tools/perf/Documentation/perf-script-python.txt >> @@ -530,7 +530,7 @@ can implement a set of optional functions: >> gives scripts a chance to do setup tasks: >> >> ---- >> -def trace_begin: >> +def trace_begin(): >> pass >> ---- >> >> @@ -539,7 +539,7 @@ def trace_begin: >> as display results: >> >> ---- >> -def trace_end: >> +def trace_end(): >> pass >> ---- >> >> -- >> 2.13.0
