On 06/08/2017 09:52 AM, Christoph Hellwig wrote: > On Thu, Jun 08, 2017 at 09:49:35AM +0200, Johannes Thumshirn wrote: >> On 06/08/2017 09:44 AM, Christoph Hellwig wrote: >>>> + if (sg_zeroout_area(req->sg, req->sg_cnt, NVME_IDENTIFY_DATA_SIZE, off) >>> >>> Shouldn;t the third argument be NVME_IDENTIFY_DATA_SIZE - off in theory? >>> It's probably fine as is as the S/G helpers deal with overflows >>> gracefully, but still.. >> >> Ahm yes. *doh* >> >> Can you fix it up when applying? > > Sure. >
Btw, is the NVMf sleftests still avtively developed? If yes I have a testcase for this series (not sure this qualifies for blktests) -- Johannes Thumshirn Storage [email protected] +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
