On 06/09/2017 03:03 AM, Greg Kroah-Hartman wrote: > We are trying to get rid of DRIVER_ATTR(), and the usbip driver > attribute can be trivially changed to use DRIVER_ATTR_RW(). > > Cc: Valentina Manea <[email protected]> > Cc: Shuah Khan <[email protected]> > Cc: <[email protected]> > Signed-off-by: Greg Kroah-Hartman <[email protected]>
Looks good to me. Acked-by: Shuah Khan <[email protected]> thanks, -- Shuah > --- > drivers/usb/usbip/stub_main.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/usbip/stub_main.c b/drivers/usb/usbip/stub_main.c > index 44ab43fc4fcc..e74fbb7f4a32 100644 > --- a/drivers/usb/usbip/stub_main.c > +++ b/drivers/usb/usbip/stub_main.c > @@ -134,7 +134,7 @@ int del_match_busid(char *busid) > return ret; > } > > -static ssize_t show_match_busid(struct device_driver *drv, char *buf) > +static ssize_t match_busid_show(struct device_driver *drv, char *buf) > { > int i; > char *out = buf; > @@ -149,7 +149,7 @@ static ssize_t show_match_busid(struct device_driver > *drv, char *buf) > return out - buf; > } > > -static ssize_t store_match_busid(struct device_driver *dev, const char *buf, > +static ssize_t match_busid_store(struct device_driver *dev, const char *buf, > size_t count) > { > int len; > @@ -181,8 +181,7 @@ static ssize_t store_match_busid(struct device_driver > *dev, const char *buf, > > return -EINVAL; > } > -static DRIVER_ATTR(match_busid, S_IRUSR | S_IWUSR, show_match_busid, > - store_match_busid); > +static DRIVER_ATTR_RW(match_busid); > > static ssize_t rebind_store(struct device_driver *dev, const char *buf, > size_t count) >
