On Thu, Jun 15, 2017 at 2:21 AM,
<[email protected]> wrote:
> From: Kuppuswamy Sathyanarayanan <[email protected]>
>
> Commit 9a752b4c9ab9 ("gpio: crystalcove: Do not write regular gpio
> registers for virtual GPIOs") added support to skip GPIO register
> update for virtual GPIOs, but it missed to add skip logic in
> crystalcove_update_irq_ctrl() function. This patch fixes it.
> @@ -134,6 +134,9 @@ static void crystalcove_update_irq_ctrl(struct
> crystalcove_gpio *cg, int gpio)
> {
> int reg = to_reg(gpio, CTRL_IN);
>
> + if (reg < 0)
> + return;
> +
> regmap_update_bits(cg->regmap, reg, CTLI_INTCNT_BE, cg->intcnt_value);
> }
Shouldn't it have been done using irq_valid_mask flag in the first place?
--
With Best Regards,
Andy Shevchenko
