On Fri, Jun 16, 2017 at 5:54 PM, Andrey Ryabinin <[email protected]> wrote: > On 06/06/2017 01:11 PM, Dmitry Vyukov wrote: >> Add arch_ prefix to all atomic operations and include >> <asm-generic/atomic-instrumented.h>. This will allow >> to add KASAN instrumentation to all atomic ops. >> >> Signed-off-by: Dmitry Vyukov <[email protected]> >> Cc: Mark Rutland <[email protected]> >> Cc: Peter Zijlstra <[email protected]> >> Cc: Will Deacon <[email protected]> >> Cc: Andrew Morton <[email protected]> >> Cc: Andrey Ryabinin <[email protected]> >> Cc: Ingo Molnar <[email protected]> >> Cc: [email protected] >> Cc: [email protected] >> Cc: [email protected] >> Cc: [email protected] >> >> --- > > > > >> -static __always_inline void atomic_set(atomic_t *v, int i) >> +static __always_inline void arch_atomic_set(atomic_t *v, int i) >> { >> + /* >> + * We could use WRITE_ONCE_NOCHECK() if it exists, similar to >> + * READ_ONCE_NOCHECK() in arch_atomic_read(). But there is no such >> + * thing at the moment, and introducing it for this case does not >> + * worth it. >> + */ > > > I'd rather remove this comment. I woudn't say that WRITE_ONCE() here looks > confusing > and needs comment. Also there is no READ_ONCE_NOCHECK() in arch_atomic_read() > anymore.
Done. It also should have gone to the patch that adds comments. > Otherwise, > Reviewed-by: Andrey Ryabinin <[email protected]> > >> WRITE_ONCE(v->counter, i); >> }
