Re: [patch v2 2/3] staging: speakup: check and convert dev name or ser to dev_t

[Dan Carpenter]

On Sun, Jun 18, 2017 at 09:58:27AM +0100, Okash Khawaja wrote:
> +int ser_to_dev(int ser, dev_t *dev_no)
> +{
> +     if (ser < 0 || ser > (255 - 64)) {
> +                pr_err("speakup: Invalid ser param. \
> +                             Must be between 0 and 191 inclusive.\n");


I pointed out that all these strings are wrong in the first version of
the patch.  You're going to end up with a whole bunch of tabs in your
dmesg output.

regards,
dan carpenter