Commit-ID:  0c788d4726c916544490c17cdbfd1ae2a6347fa8
Gitweb:     http://git.kernel.org/tip/0c788d4726c916544490c17cdbfd1ae2a6347fa8
Author:     Kim Phillips <kim.phill...@arm.com>
AuthorDate: Thu, 15 Jun 2017 12:55:21 -0500
Committer:  Arnaldo Carvalho de Melo <a...@redhat.com>
CommitDate: Mon, 19 Jun 2017 15:27:08 -0300

perf coresight: Remove superfluous check before use

The cs_etm_evsel variable is guaranteed to be set at this point in
cs_etm_recording_options().

Signed-off-by: Kim Phillips <kim.phill...@arm.com>
Acked-by: Mathieu Poirier <mathieu.poir...@linaro.org>
Cc: Alexander Shishkin <alexander.shish...@linux.intel.com>
Cc: Peter Zijlstra <pet...@infradead.org>
Cc: linux-arm-ker...@lists.infradead.org
Link: http://lkml.kernel.org/r/20170615125521.80cc128dc856bc1f2e61b...@arm.com
Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com>
---
 tools/perf/arch/arm/util/cs-etm.c | 25 ++++++++++++-------------
 1 file changed, 12 insertions(+), 13 deletions(-)

diff --git a/tools/perf/arch/arm/util/cs-etm.c 
b/tools/perf/arch/arm/util/cs-etm.c
index 02a649b..7ce3d1a 100644
--- a/tools/perf/arch/arm/util/cs-etm.c
+++ b/tools/perf/arch/arm/util/cs-etm.c
@@ -203,19 +203,18 @@ static int cs_etm_recording_options(struct 
auxtrace_record *itr,
                pr_debug2("%s snapshot size: %zu\n", CORESIGHT_ETM_PMU_NAME,
                          opts->auxtrace_snapshot_size);
 
-       if (cs_etm_evsel) {
-               /*
-                * To obtain the auxtrace buffer file descriptor, the auxtrace
-                * event must come first.
-                */
-               perf_evlist__to_front(evlist, cs_etm_evsel);
-               /*
-                * In the case of per-cpu mmaps, we need the CPU on the
-                * AUX event.
-                */
-               if (!cpu_map__empty(cpus))
-                       perf_evsel__set_sample_bit(cs_etm_evsel, CPU);
-       }
+       /*
+        * To obtain the auxtrace buffer file descriptor, the auxtrace
+        * event must come first.
+        */
+       perf_evlist__to_front(evlist, cs_etm_evsel);
+
+       /*
+        * In the case of per-cpu mmaps, we need the CPU on the
+        * AUX event.
+        */
+       if (!cpu_map__empty(cpus))
+               perf_evsel__set_sample_bit(cs_etm_evsel, CPU);
 
        /* Add dummy event to keep tracking */
        if (opts->full_auxtrace) {

Reply via email to